Issue 64 take2 #93
Merged
Issue 64 take2 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsnaps
commented
Jul 20, 2022
limitador/src/limit.rs
Outdated
| @@ -26,8 +26,10 @@ impl From<String> for Namespace { | |||
| #[derive(Eq, Debug, Clone, Serialize, Deserialize)] | |||
| pub struct Limit { | |||
| namespace: Namespace, | |||
| #[serde(skip_serializing)] | |||
There was a problem hiding this comment.
Not sure why I changed that in the first PR, but this still needs to read these values when reading the LIMITS_FILE obviously… otherwise all limits are 0 🤦♂️
2 tasks
eguzki
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #64 for real?