Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RaterLimiter to take a &Namespace #77

Merged
merged 1 commit into from
Jun 9, 2022
Merged

RaterLimiter to take a &Namespace #77

merged 1 commit into from
Jun 9, 2022

Conversation

alexsnaps
Copy link
Member

This is based of #76
I think this is cleaner (and avoids a couple .clone()s along the way). If we all agree, this could be merged.

@rahulanand16nov
Copy link
Contributor

Let's merge #76 and rebase this. I'll review it then.

rahulanand16nov
rahulanand16nov approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@rahulanand16nov rahulanand16nov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsnaps alexsnaps merged commit 6e34ef7 into main Jun 9, 2022
@alexsnaps alexsnaps deleted the just_call_it branch June 9, 2022 19:39
@alexsnaps alexsnaps added this to the Limitador v0.3 milestone Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulanand16nov rahulanand16nov rahulanand16nov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Limitador v0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@alexsnaps @rahulanand16nov