add back David's name into the authors list #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eguzki
reviewed
Jun 7, 2022
limitador-server/Cargo.toml
Outdated
| @@ -1,7 +1,7 @@ | |||
| [package] | |||
| name = "limitador-server" | |||
| version = "0.5.1" | |||
| authors = ["Eguzki Astiz Lezaun <[email protected]>"] | |||
| authors = ["Eguzki Astiz Lezaun <[email protected]>", "David Ortiz <[email protected]>"] | |||
There was a problem hiding this comment.
Suggested change
| authors = ["Eguzki Astiz Lezaun <[email protected]>", "David Ortiz <[email protected]>"] | |
| authors = ["Rahul Anand <[email protected]>", "Eguzki Astiz Lezaun <[email protected]>", "David Ortiz <[email protected]>"] |
|
@davidor I think current maintainers should be first on the list, is it okay with you? Can we get ownership of https://crates.io/crates/limitador so we can push the new release? |
alexsnaps
approved these changes
Jun 8, 2022
|
Let's wait for @davidor's reply before merging this. |
|
@alexsnaps should be also added |
|
@rahulanand16nov you did not accept my suggested change |
|
@eguzki I haven't contributed much yet but will add once I have contributed in a bit more significant way 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think @davidor 's name was removed mistakenly. Though he's not going to contribute still he's still an author, right? :)