-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥 conditions et at, replacing with proper cel::Predicate
s & ::Expression
s
#396
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d4296ec
Basic cel::Expression & ::Predicate impl
alexsnaps 83c5f8a
Impl Error::source for EvaluationError
alexsnaps 2a53ce8
Serialization and other traits for CEL types
alexsnaps d895098
Replaced `Condition`s with `cel::Predicate`s
alexsnaps 8488bae
req. is not valid and there is no magic
alexsnaps 16ad79e
🔥 feature lenient_conditions
alexsnaps e212b0e
🔥 module crate::limit::conditions et al
alexsnaps d3911b9
Inject Limit id & name into Context
alexsnaps a1e9304
Slightly rearranged/cleaned deps
alexsnaps d60e5f7
Parse Limit's Predicates on creation
alexsnaps 1652ba8
Parse Limit's variables as exp and resolve
alexsnaps 9fe7d80
key variable with full expression
alexsnaps 7c33b77
More time needed sometimes
alexsnaps b816ec3
Opening seam for injectable root
alexsnaps db9b97f
Properly check for variables when they are cel
alexsnaps ef45382
Treat CEL NoSuchKey as ignored false in pred, and miss in keys
alexsnaps 345be88
Support for list values as binding to cel::Context
alexsnaps e0ae4f6
Expose Context all the way up
alexsnaps 7cc4ff4
Fixed test and take ownership of vars in ctx
alexsnaps 8941898
Wired proper descriptor wiring into context
alexsnaps File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now a breaking change obviously...
We could tell the server to not do that tho. But this is the only way I can think of to support multiple
RateLimitDescriptor
coming in from envoy, as well as the fact that each of their entries areString, String
... i.e. any valid utf-8 string, which for thekey
has to be exposed as aMap<String, _>
somehow.For Kuadrant tho, we can now use the
limit.id == '3f5e80af-1056-4349-bb84-c8010f34ecbb'
if we'd wanted (and wire theid
field of theLimit
itself in the config)... eventually this semantic could then be optimized for