Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh action: license scan by fossa #369

Merged
merged 1 commit into from
Aug 22, 2024
Merged

gh action: license scan by fossa #369

merged 1 commit into from
Aug 22, 2024

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Aug 21, 2024

No description provided.

Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
@eguzki eguzki requested a review from david-martin August 21, 2024 15:55
@eguzki
Copy link
Contributor Author

eguzki commented Aug 21, 2024

Failing because we actually have an issue with the licenses. Explained in #368

@david-martin
Copy link
Member

@eguzki the details are a little lacking in the logs :(
https://github.com/Kuadrant/limitador/actions/runs/10493245985/job/29066736342?pr=369
I wonder if that would give more info if a non push-only key was used?
Or if there's a way to provide a handy link to the fossa project page?

@eguzki
Copy link
Contributor Author

eguzki commented Aug 22, 2024

Changing the key no another one with full permissions.

After telling Fossa to ignore the dual license false positive, tests now pass.

@eguzki
Copy link
Contributor Author

eguzki commented Aug 22, 2024

Fossa scanning/testing works as follows: First step is scan phase. That scanning does not happen locally, but at Fossa servers. The report is then available in their site on completion.

If you check the scan step in our workflow, you will see the scan step provides a link: https://app.fossa.com/projects/custom%2b162%2fgit%2bgithub.com%2fKuadrant%2flimitador/refs/branch/fossa-scan/0458484c3719b3141af936912562731164ac24a4

The run step waits for scan completion and then fails if there are issues.

PS: The link above no longer shows issues, because latest scan on the same revision returned no issues.

Copy link
Member

@david-martin david-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @eguzki
Good to have this automated at PR time

@eguzki eguzki merged commit 05a8ae9 into main Aug 22, 2024
10 checks passed
@eguzki eguzki deleted the fossa-scan branch August 22, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants