Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove_generated_code #30

Closed
wants to merge 4 commits into from
Closed

remove_generated_code #30

wants to merge 4 commits into from

Conversation

andrewdavidmackenzie
Copy link
Contributor

Generate code for protobuf in "OUT_DIR" not under src/ and remove those files from version control.

davidor
davidor reviewed Mar 22, 2021
View reviewed changes
limitador-server/src/envoy_rls/envoy_types.rs Outdated
#[path = "envoy.config.core.v3.rs"]
pub mod v3;
pub mod v3 {
include!(concat!(env!("OUT_DIR"), "/envoy.config.core.v3.rs"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We switched from include! to path because @unleashed mentioned that include! does not work in some IDEs #5 (comment)

@davidor
Copy link
Contributor

davidor commented Mar 22, 2021

@andrewdavidmackenzie This PR breaks the Intellij integration for me. Intellij is not able to find the files generated from the protobufs and it shows in red all the structs like Code, Entry, etc. in limitador-server/src/envoy_rls/server.rs. is it the same for you or did you somehow fix it?

@davidor
Copy link
Contributor

davidor commented Mar 22, 2021

rustfmt fails because there's a missing newline at the end of limitador/src/storage/redis/redis_sync.rs

@andrewdavidmackenzie
Copy link
Contributor Author

@davidor using #[path] instead of include!() works, but IntelliJ still cannot find the files, as it's looking in /src I assume.
Not sure if that is fixable, as they are generated in a build directory with a unique number, so you cannot even map it as a source file in IntelliJ.

@alexsnaps
Copy link
Member

alexsnaps commented Aug 25, 2022 •
edited
Loading

I think this has been addressed as part of #104 - reopen if I'm wrong!
Works on my computer™… with CLion

@alexsnaps alexsnaps closed this Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidor davidor davidor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewdavidmackenzie @davidor @alexsnaps