Partion resilience #268
Closed
Partion resilience #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsnaps
force-pushed
the
partion-resilience
branch
2 times, most recently
from
8761a42 to
ca921b2
Compare
alexsnaps
force-pushed
the
partion-resilience
branch
from
ca921b2 to
98d6b4f
Compare
alexsnaps
commented
Mar 14, 2024
| let storage = RedisLenient::new(storage); | ||
| let arc = Arc::new(storage); | ||
| let copy = arc.clone(); | ||
| tokio::spawn(async move { copy.sanity_check(Duration::from_secs(5)).await }); |
There was a problem hiding this comment.
This needs to be configurable…
| pub async fn is_alive(&self) -> bool { | ||
| self.conn_manager | ||
| .clone() | ||
| .incr::<&str, i32, u64>("LIMITADOR_LIVE_CHECK", 1) |
There was a problem hiding this comment.
This probably needs to be configurable as well…
Comment on lines
+22
to
+36
| if self.is_partitioned() { | ||
| self.fallback.is_within_limits(counter, delta) | ||
| } else { | ||
| self.redis | ||
| .is_within_limits(counter, delta) | ||
| .await | ||
| .or_else(|err| { | ||
| if err.is_transient() { | ||
| self.partitioned(true); | ||
| self.fallback.is_within_limits(counter, delta) | ||
| } else { | ||
| Err(err) | ||
| } | ||
| }) | ||
| } |
There was a problem hiding this comment.
This pattern could be extracted in a macro possible
| self.fallback.get_counters(&limits) | ||
| } else { | ||
| self.redis | ||
| .get_counters(limits.clone()) |
There was a problem hiding this comment.
Refactor this to have the limits: HashSet<Limit> be returned back as part of the Err to avoid the (early?) .clone() here
alexsnaps
force-pushed
the
partion-resilience
branch
from
d00d91f to
c67ee2f
Compare
|
Closing in favor of #279 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a shot at starting to address #265