fix image build on main branch

[eguzki]

The main docker image tag has not been built for a while. Same for image builds with git sha tags from the main branch.

[alexsnaps]

I actually had removed that… Cause I probably misunderstood the intent...
main is the equivalent of latest, always, right? So why do we need the two tags? Why can't we just use latest (ormain actually, I don't mind really - tho latest conveys more than main). Why do we need both...?

[guicassolato]

I've seen that missing and thought it was intentional. Sorry.

[eguzki]

The actual intention was to generate the tag with the git sha, which is being used in the smoke test. I agree that main branch is the same as latest, hence useless. Question: do we want git sha tag to be generated of al lthe mainbranch commits?? I thought is was wanted for continuous testing (bundles passed to QE reference images with git sha tag).

[alexsnaps]

do we want git sha tag to be generated of al lthe mainbranch commits?? I thought is was wanted for continuous testing (bundles passed to QE reference images with git sha tag).

I think we want to, yes… I'm just pondering the utility of main and latest… And if they are redundant, I'm arguing to keep the latter, i.e. latest. I think having the sha was the intent, but @didierofrivia or @pehala might correct me…

[eguzki]

ok, let me change a bit to have only latest and the git sha for the main branch

[alexsnaps]

can we have this just be: github.sha for this step, where ref_name is main?

[alexsnaps]

ugh nevermind that comment, I somehow never submitted this 🤔