fix(error): Bubble error up to main when connecting to Redis fails #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eguzki
reviewed
Oct 11, 2022
eguzki
reviewed
Oct 11, 2022
eguzki
reviewed
Oct 11, 2022
Yeah, I mostly cared about the server binary, which leverages the async version. But yeah, I should totally do the sync version as well… otherwise this is weird. |
Both in sync redis as well as the cached version
alexsnaps
force-pushed
the
issue_100
branch
2 times, most recently
from
a12935f to
ba5134d
Compare
alexsnaps
commented
Oct 17, 2022
| // this panic!s And I really don't see how to bubble the redis error back up: | ||
| // r2d2 consumes it | ||
| // RedisError are not publicly constructable | ||
| // So using String as error type… sad |
eguzki
reviewed
Oct 18, 2022
| .unwrap(); | ||
| ) -> Result<Self, RedisError> { | ||
| let info = ConnectionInfo::from_str(redis_url)?; | ||
| let redis_conn_manager = ConnectionManager::new(redis::Client::open(info).unwrap()).await?; |
There was a problem hiding this comment.
nitpick: maybe expect instead of unwrap for consistency?
eguzki
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No magic here…
Fixes #100