Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for != in conditions #113

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Add support for != in conditions #113

merged 1 commit into from
Sep 1, 2022

Conversation

alexsnaps
Copy link
Member

@alexsnaps alexsnaps commented Aug 30, 2022

Closes #18
I'd rather not add regex support at this stage because of there non-predictable performance profiles (depending on their impl. arguably, we'd want compiled DFAs, but even then…)… when someone really requires it, we can look into adding it.

@alexsnaps alexsnaps changed the base branch from lenient to scanner September 1, 2022 13:08
@alexsnaps alexsnaps marked this pull request as ready for review September 1, 2022 13:26
@alexsnaps alexsnaps changed the base branch from scanner to main September 1, 2022 17:32
@alexsnaps alexsnaps merged commit 47d3b66 into main Sep 1, 2022
@alexsnaps alexsnaps deleted the not_equal branch September 1, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support more operations in conditions
2 participants