Updated dependencies #112
Updated dependencies #112
Conversation
| @@ -6,7 +6,7 @@ license = "Apache-2.0" | |||
| keywords = ["rate-limiting", "rate", "limiter", "envoy", "rls"] | |||
| categories = ["web-programming"] | |||
| description = "Rate limiting service that integrates with Envoy's RLS protocol" | |||
| homepage = "https://github.com/kuadrant/limitador" | |||
| homepage = "https://kuadrant.io" | |||
There was a problem hiding this comment.
If the limitador-server crate is not being published, where is this information being exposed? (in addition to in the Cargo.toml in the GH repo)
Anyway, for me the homepage is (was) correct. Maybe in the "READMEwe should add reference tohttps://kuadrant.io`. Not a strong opinion, though.
There was a problem hiding this comment.
Which ever… we can also not have a homepage (also, to be clear, there is repository that points to github still)
| license = "Apache-2.0" | ||
| keywords = ["rate-limiting", "rate", "limiter"] | ||
| categories = ["web-programming"] | ||
| description = "Rate limiting library" | ||
| homepage = "https://github.com/kuadrant/limitador" | ||
| homepage = "https://kuadrant.io" |
There was a problem hiding this comment.
not sure about this, since this crate is publish in crates.io
Aligned with the previous comment, I would leave it as it was, but it is ok as you propose.
limitador-server/Cargo.toml
Outdated
| @@ -6,7 +6,7 @@ license = "Apache-2.0" | |||
| keywords = ["rate-limiting", "rate", "limiter", "envoy", "rls"] | |||
| categories = ["web-programming"] | |||
| description = "Rate limiting service that integrates with Envoy's RLS protocol" | |||
| homepage = "https://github.com/kuadrant/limitador" | |||
| homepage = "https://kuadrant.io" | |||
| repository = "https://github.com/kuadrant/limitador" | |||
| documentation = "https://docs.rs/limitador" | |||
There was a problem hiding this comment.
I'd probably get rid of the documentation here, or have it point to kuadrant.io/docs/limitador-server? (There will be better content there soon™)
| @@ -22,6 +22,9 @@ jobs: | |||
| profile: minimal | |||
| toolchain: stable | |||
| override: true | |||
| - uses: abelfodil/protoc-action@v1 | |||
There was a problem hiding this comment.
just for curiosity, why is this new step needed now?
There was a problem hiding this comment.
libssl3from container image, as this was introduced byreqwest/infinispanauthors… but it isn't complete… confused?