Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling the --rate-limit-headers polutes the keyspace in Redis #312

Closed
alexsnaps opened this issue May 2, 2024 · 0 comments · Fixed by #313
Closed

Enabling the --rate-limit-headers polutes the keyspace in Redis #312

alexsnaps opened this issue May 2, 2024 · 0 comments · Fixed by #313
Labels
kind/bug Something isn't working

Comments

@alexsnaps
Copy link
Member

Since we mutate the Counters by setting the remaining & expires_in fields, and we are doing so prior invoking the SCRIPT_UPDATE_COUNTER, which also sadd the key to a set for that limit in redis, this creates dups for all these counters.
We probably need to refactor this so that we differentiate between CounterKey and Counter types properly

@alexsnaps alexsnaps added the kind/bug Something isn't working label May 2, 2024
alexsnaps added a commit that referenced this issue May 2, 2024
@alexsnaps alexsnaps linked a pull request May 2, 2024 that will close this issue
alexsnaps added a commit that referenced this issue May 2, 2024
alexsnaps added a commit that referenced this issue May 3, 2024
@github-project-automation github-project-automation bot moved this to Done in Kuadrant May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant