Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get enable_x_ratelimit_headers: DRAFT_VERSION_03 to work #156

Closed
4 tasks done
chirino opened this issue Mar 13, 2023 · 1 comment
Closed
4 tasks done

Get enable_x_ratelimit_headers: DRAFT_VERSION_03 to work #156

chirino opened this issue Mar 13, 2023 · 1 comment
Assignees
@eguzki
Labels
area/server kind/enhancement New feature or request size/medium target/current

Comments

@chirino
Copy link
Contributor

chirino commented Mar 13, 2023 •
edited by eguzki
Loading

I tried setting the enable_x_ratelimit_headers option in the envoy rate limiting filter. But the expected headers were not set in the response.

the filter's configuration looks like:

                  - name: envoy.filters.http.ratelimit
                    typed_config:
                      "@type": type.googleapis.com/envoy.extensions.filters.http.ratelimit.v3.RateLimit
                      domain: nexodus
                      failure_mode_deny: false
                      timeout: 0.05s
                      enable_x_ratelimit_headers: DRAFT_VERSION_03
                      rate_limit_service:
                        transport_api_version: V3
                        grpc_service:
                          envoy_grpc:
                            cluster_name: ratelimiter

The only header I see in the responses is x-envoy-ratelimited: true, I was hoping to get headers like X-RateLimit-Limit: 10, 10;w=1;name="per-ip", 1000;w=3600

Tasks
chirino added a commit to chirino/limitador that referenced this issue Mar 19, 2023
@chirino
Adding response headers in the RLS server so that it implements https…
956be59 
…://datatracker.ietf.org/doc/id/draft-polli-ratelimit-headers-03.html

See issue Kuadrant#156
@chirino chirino mentioned this issue Mar 19, 2023
Closed
chirino added a commit to chirino/limitador that referenced this issue Mar 20, 2023
@chirino
Adding response headers in the RLS server so that it implements https…
4ef5e01 
…://datatracker.ietf.org/doc/id/draft-polli-ratelimit-headers-03.html

See issue Kuadrant#156
chirino added a commit to chirino/limitador that referenced this issue Mar 20, 2023
@chirino
Adding response headers in the RLS server so that it implements https…
c373724 
…://datatracker.ietf.org/doc/id/draft-polli-ratelimit-headers-03.html

See issue Kuadrant#156
chirino added a commit to chirino/limitador that referenced this issue Mar 20, 2023
@chirino
Adding response headers in the RLS server so that it implements https…
dacd955 
…://datatracker.ietf.org/doc/id/draft-polli-ratelimit-headers-03.html

See issue Kuadrant#156
chirino added a commit to chirino/limitador that referenced this issue Mar 21, 2023
@chirino
Adding response headers in the RLS server so that it implements https…
eddf0d3 
…://datatracker.ietf.org/doc/id/draft-polli-ratelimit-headers-03.html

See issue Kuadrant#156
@chirino chirino mentioned this issue Mar 21, 2023
Merged
@alexsnaps alexsnaps moved this to In Progress in Kuadrant Service Protection Apr 13, 2023
@eguzki eguzki moved this from In Progress to To test in Kuadrant Service Protection Apr 17, 2023
@pehala
Copy link

pehala commented May 9, 2023

Not tested by QE currently.

@pehala pehala closed this as completed May 9, 2023
@pehala pehala moved this from To test to Done in Kuadrant Service Protection May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eguzki eguzki

Labels
area/server kind/enhancement New feature or request size/medium target/current
Projects
No open projects
Kuadrant Service Protection
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chirino @alexsnaps @eguzki @pehala