Use increments in Redis

Kuadrant · Apr 2, 2024 · 1329e72 · 1329e72
1 parent 67f74d4
commit 1329e72
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/limitador-server/examples/limits.yaml b/limitador-server/examples/limits.yaml
@@ -2,16 +2,14 @@
 -
   namespace: test_namespace
   max_value: 10
-  seconds: 60
+  seconds: 10
   conditions:
     - "req.method == 'GET'"
   variables:
-    - user_id
 -
   namespace: test_namespace
   max_value: 5
-  seconds: 60
+  seconds: 10
   conditions:
     - "req.method == 'POST'"
   variables:
-    - user_id
diff --git a/limitador/src/storage/redis/counters_cache.rs b/limitador/src/storage/redis/counters_cache.rs
@@ -204,7 +204,7 @@ mod tests {
     }
 
     #[test]
-    fn insert_saves_0_when_redis_val_is_none() {
+    fn insert_saves_zero_when_redis_val_is_none() {
         let max_val = 10;
         let mut values = HashMap::new();
         values.insert("app_id".to_string(), "1".to_string());

diff --git a/limitador/src/storage/redis/redis_cached.rs b/limitador/src/storage/redis/redis_cached.rs
@@ -138,7 +138,9 @@ impl AsyncCounterStorage for CachedRedisStorage {
                         counter_ttls_msecs[i],
                         ttl_margin,
                     );
-                    let remaining = counter.max_value() - counter_vals[i].unwrap_or(0) - delta;
+                    let remaining = counter.max_value()
+                        - counter_vals[i].unwrap_or(0)
+                        - delta;
                     if first_limited.is_none() && remaining < 0 {
                         first_limited = Some(Authorization::Limited(
                             counter.limit().name().map(|n| n.to_owned()),