-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable configuring PDB from Limitador CR #91
Conversation
29f7634
to
b541fb3
Compare
Codecov Report
@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 43.31% 43.83% +0.52%
==========================================
Files 11 12 +1
Lines 718 803 +85
==========================================
+ Hits 311 352 +41
- Misses 369 408 +39
- Partials 38 43 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
a38a173
to
901d7a7
Compare
901d7a7
to
db301ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy path works but I did find two issue that will need to be addressed.
- The user is allowed to state the selector fields in the limitador CR but this ignored by the operator. In this case it might better to not allow the user state the selector fields.
- The selector field of
app
is not unique and would apply to multiply limitador CR deploy of which all may have different conflicting PDB polices.
There are a few smaller comments but that is the big points.
Co-authored-by: Grzegorz Piotrowski <[email protected]>
db301ce
to
b9a7371
Compare
8a4a0c9
to
e3d5280
Compare
Co-authored-by: Grzegorz Piotrowski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the issue and change request have being addressed. I would be happy to see this merged.
Added ability to configure
PodDisruptionBudget
from Limitador CR.Defining a limitador CR with the pdb set results in an associated
PodDisruptionBudget
object to be created.Also added new make target
make local-redeploy
that re-builds image locally and rolls out deployment in kind cluster with the local changes.Resolves #75