limitador version from env var

[eguzki]

what

Limitador image can be read from RELATED_IMAGE_LIMITADOR env var. Defaults to quay.io/3scale/limitador:latest-

Required to specify the limitador image from the CSV manifest

spec.version will override any value from RELATED_IMAGE_LIMITADOR.

The limitador image order of preference is:

• spec.version value (only allows tag, repo will alway be quay.io/3scale/limitador
• value from RELATED_IMAGE_LIMITADOR env var. Image repo and tag needs to be specified. For example: quay.io/3scale/limitador:0.5.1
• Default value: quay.io/3scale/limitador:latest

Verification steps

run cluster

make local-setup-kind

install CRDs

make install

run operator locally with specific RELATED_IMAGE_LIMITADOR env var.

RELATED_IMAGE_LIMITADOR=quay.io/3scale/limitador:0.5.1 make run

Create Limitador object without spec.version to deploy version from env var.

k apply -f - <<EOF
apiVersion: limitador.kuadrant.io/v1alpha1
kind: Limitador
metadata:
  name: limitador-sample
spec:
  limits:
    - conditions: ["get-toy == yes"]
      max_value: 2
      namespace: toystore-app
      seconds: 30
      variables: []
EOF

Check limitador's version is quay.io/3scale/limitador:0.5.1

$ k get deployment limitador-sample -o yaml | yq e '.spec.template.spec.containers[0].image' -
quay.io/3scale/limitador:0.5.1

[didierofrivia]

Changes make sense, we could quick discuss the minor comments I've left 👍🏼

[didierofrivia]

Maybe rename it to something like LIMITADOR_SERVICE_IMAGE or LIMITADOR_INSTANCE_IMAGE or just LIMITADOR_IMAGE ... regarding the last one, we could make the distinction with LIMITADOR_OPERATOR_IMAGE if needed

[eguzki]

RELATED_IMAGE prefix is commonly in OSBS for productization purposes.

I am preparing it for the future

[eguzki]

Actually, the relatedImages section in the bundle is automatically created because of that prefix is being used.

[didierofrivia]

Maybe you are thinking on having extra capabilities for the image and repository, but if not we could simply use FetchEnv here like:

image := helpers.FetchEnv(RELATED_IMAGE_LIMITADOR, fmt.Sprintf("%s:%s", LimitadorRepository, DefaultVersion) )

[eguzki]

I only included the logic in a method to be testable in image_test.go