Limitador Service Settings #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didierofrivia
force-pushed
the
service-settings
branch
from
20d2107 to
c9346ce
Compare
eguzki
reviewed
Jun 1, 2022
didierofrivia
force-pushed
the
service-settings
branch
2 times, most recently
from
f42564c to
03ff076
Compare
didierofrivia
commented
Jun 10, 2022
didierofrivia
commented
Jun 10, 2022
eguzki
reviewed
Jun 14, 2022
didierofrivia
force-pushed
the
service-settings
branch
from
2fafa43 to
a3525a6
Compare
* Created NamespacedName type just to add serialization details
* It gets the URL from Limitador.Status * It retrieves the right Limitador from its Spec or Default
* Listener instead of Service, to be aligned with other projects * Defining a TransferProtocol for Ports, allowing for future TLS features * Getting the name of the Limitador Obj for the Service Name
didierofrivia
force-pushed
the
service-settings
branch
from
a3525a6 to
c3112ad
Compare
eguzki
approved these changes
Jun 16, 2022
| @@ -62,6 +64,11 @@ type RateLimitList struct { | |||
| Items []RateLimit `json:"items"` | |||
| } | |||
|
|
|||
| type NamespacedName struct { | |||
There was a problem hiding this comment.
it exists in apimachinery https://pkg.go.dev/k8s.io/apimachinery/pkg/types#NamespacedName
| // Simple enough now, we could implement a thorough check like with RateLimit with ObservedGeneration in the future | ||
| builtServiceUrl := buildServiceUrl(limitadorObj) | ||
| if builtServiceUrl != limitadorObj.Status.ServiceURL { | ||
| logger.V(1).Info("Updating the Status", "Name", limitadorObj.Name) |
There was a problem hiding this comment.
no need, already includes the name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
This PR introduces a couple of changes that aim to fix the hardcoded values taken for creating/discovering Limitador Services. The Limitador Operator is meant to have the "ownership" of the Limitador Instance (the actual service), which means it will have the source of truth regarding the Service params, and it's the place to define those.
On the
LimitadorcontrollerStatusout of a newSpec.Listenertype andLimitador.NameSpec.Listeneris marked asoptionaland when it's not present, the values are retrieved from defaultconstOn the
RateLimitcontrollerLimitadorRefwithin theRateLimitspecoptionaltoo, will get the values out of default const (as before)namespacedNameto fetch itsStatus.ServiceURL