-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manifest files for easy prototyping #17
Conversation
7aafa6e
to
b7b9509
Compare
5f70ec2
to
0af5579
Compare
There was one typo in |
0af5579
to
49dd7f4
Compare
Weird, the last run was two tests failing and now only one, but I am passing all the tests locally? Flaky tests? |
Is there no way to use the manifests already generated for the bundle? https://github.com/Kuadrant/limitador-operator/tree/main/bundle/manifests I'm not sure everything (Roles/RoleBindlings) is included though ... If you are generating file(s) that need to be committed, you might want to consider adding a CI job to ensure they are always regenerated correctly before allowing changes to be merged https://github.com/Kuadrant/kuadrant-operator/blob/main/.github/workflows/test.yaml#L109 https://github.com/Kuadrant/kuadrant-operator/blob/main/make/verify.mk |
49dd7f4
to
6741f0e
Compare
I guess the requirement was to have a single document but I am not sure... @guicassolato any thoughts? Edit: Good idea to verify generated manifests. 🤔 |
Suggestion was indeed motivated by the desire to install and deploy the operator from one single YAML file, like option provided by https://github.com/kuadrant/authorino-operator. With OLM, theoretically we could list all the steps (or have a tool) to automate: downloading the CSV bundle, applying the manifests, creating catalog source, subscription, etc. However, I don't see that being much simpler for the command-line than In the Authorino docs, we have user guides such as this one, where Limitador is deployed and a rate limit config defined, all without support from the operator. I would like to enhance that one step into:
More explicit, yet with minimum number of commands for the user to follow.
+1 to that. |
6741f0e
to
b070d37
Compare
@mikenairn added a verifying script which gets executed in the CI. Please merge if looks good to you. |
/lgtm |
This PR tries to address Issue #16 to provide manifest files for situations where cloning the whole operator repo is not necessary.