Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest files for easy prototyping #17

Merged
merged 4 commits into from
Jan 11, 2022

Conversation

rahulanand16nov
Copy link
Contributor

This PR tries to address Issue #16 to provide manifest files for situations where cloning the whole operator repo is not necessary.

@rahulanand16nov rahulanand16nov changed the title manifests file for easy protoyping manifest files for easy protoyping Jan 10, 2022
@rahulanand16nov rahulanand16nov changed the title manifest files for easy protoyping manifest files for easy prototyping Jan 10, 2022
@rahulanand16nov
Copy link
Contributor Author

There was one typo in kustomization.yaml file which was failing deployment manifest but I hope its fixed now.

Makefile Show resolved Hide resolved
@rahulanand16nov
Copy link
Contributor Author

Weird, the last run was two tests failing and now only one, but I am passing all the tests locally? Flaky tests?

@mikenairn
Copy link
Member

Is there no way to use the manifests already generated for the bundle? https://github.com/Kuadrant/limitador-operator/tree/main/bundle/manifests I'm not sure everything (Roles/RoleBindlings) is included though ...

If you are generating file(s) that need to be committed, you might want to consider adding a CI job to ensure they are always regenerated correctly before allowing changes to be merged https://github.com/Kuadrant/kuadrant-operator/blob/main/.github/workflows/test.yaml#L109 https://github.com/Kuadrant/kuadrant-operator/blob/main/make/verify.mk

@rahulanand16nov
Copy link
Contributor Author

rahulanand16nov commented Jan 10, 2022

Is there no way to use the manifests already generated for the bundle? https://github.com/Kuadrant/limitador-operator/tree/main/bundle/manifests I'm not sure everything (Roles/RoleBindlings) is included though ...

I guess the requirement was to have a single document but I am not sure... @guicassolato any thoughts?

Edit: Good idea to verify generated manifests. 🤔

@guicassolato
Copy link
Contributor

I guess the requirement was to have a single document but I am not sure... @guicassolato any thoughts?

Suggestion was indeed motivated by the desire to install and deploy the operator from one single YAML file, like option provided by https://github.com/kuadrant/authorino-operator.

With OLM, theoretically we could list all the steps (or have a tool) to automate: downloading the CSV bundle, applying the manifests, creating catalog source, subscription, etc. However, I don't see that being much simpler for the command-line than git clone ... && make install deploy. I wanted to avoid too may steps and having to download operator files locally.

In the Authorino docs, we have user guides such as this one, where Limitador is deployed and a rate limit config defined, all without support from the operator. I would like to enhance that one step into:

  1. Deploy the Limitador Operator
  2. Create a Limitador CR
  3. Create a RateLimit CR

More explicit, yet with minimum number of commands for the user to follow.

Edit: Good idea to verify generated manifests. 🤔

+1 to that.

@rahulanand16nov
Copy link
Contributor Author

@mikenairn added a verifying script which gets executed in the CI. Please merge if looks good to you.

@mikenairn
Copy link
Member

/lgtm

@mikenairn mikenairn merged commit 832f329 into Kuadrant:main Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants