🔥 "replaces" from bundle #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
- Coverage 84.73% 84.34% -0.40%
==========================================
Files 19 19
Lines 1009 1009
==========================================
- Hits 855 851 -4
- Misses 102 104 +2
- Partials 52 54 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
eguzki
force-pushed
the
remove-replaces-from-bundle
branch
from
245bfad to
e9d8515
Compare
Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For OLM from custom catalogs, replaces does not make sense as the catalog has only one bundle.
For OLM from public catalogs, we switched recently to
semver-mode, so the "replaces" are automatically computed by OLM https://github.com/k8s-operatorhub/community-operators/pull/5074/files#diff-065802dd933715bcbb9102cf0ec632f16e00b47c9aafda66865c08e3c00fbda2R1Helm charts not affected (AFAICT)
In conclusion, no need for
replacesfield. 🔥 to it.