Docker image with git sha only for pushes on main branch #155
Conversation
eguzki
changed the title
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
- Coverage 85.91% 85.01% -0.91%
==========================================
Files 19 19
Lines 994 994
==========================================
- Hits 854 845 -9
- Misses 92 97 +5
- Partials 48 52 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
eguzki
force-pushed
the
fix-image-build
branch
from
40898be to
cf8e637
Compare
| if: ${{ github.ref_name == env.MAIN_BRANCH_NAME }} | ||
| id: add-git-sha-tag | ||
| run: | | ||
| echo "IMG_TAGS=${{ github.sha }} ${{ env.IMG_TAGS }}" >> $GITHUB_ENV |
There was a problem hiding this comment.
I understand Build images for main branch will trigger a build when commits are pushed to main. By not specifying operatorTag, these builds will be tagged latest (default) and <commit-sha> (added in this line).
Build images for dev branches will NOT trigger a build for main due to the if condition added (to make sure only pushes to feature branches will do it). However, Schedule build with latest image SHA versions will trigger another build, and by specifying operatorTag = <commit-sha>, these images will have the <commit-sha> tag only (redundantly added here) and will separate from latest (previously built, on a different manifest).
Q: Do we need to keep Schedule build with latest image SHA versions? Is it because it specifies limitadorVersion? If we are to keep it, can we please remove the operatorTag param there (so it assumes latest by default)? In this case, would we still need Build images for main branch?
There was a problem hiding this comment.
IMO, we probably want to keep Build images for main branch and get rid of Schedule build with latest image SHA versions. Maybe add limitadorVersion to the former?
There was a problem hiding this comment.
I was about to delete the scheduled build with the latest image with the git sha tag. But then I realized that this build is actually the correct one. The build triggered from push to main is not correct.
We need to fix this in a following up PR
That's good enough, @guicassolato ?
There was a problem hiding this comment.
IDK. I don't really like that main is built twice today. I would get rid of the scheduled one right away and add limitadorVersion: ${{ vars.LIMITADOR_SHA }} to the build main one.
There was a problem hiding this comment.
Oh! Too soon. I see the problem with that now... When the operand changes, nothing will rebuild the operator with the updated SHA, right? Damn!
There was a problem hiding this comment.
So add limitadorVersion: ${{ vars.LIMITADOR_SHA }} to build main and remove this line but keep both workflows? main will build twice but at least both tags will be added and linked every time. Right?
There was a problem hiding this comment.
Oh! Too soon. I see the problem with that now... When the operand changes, nothing will rebuild the operator with the updated SHA, right? Damn!
Right.
The other option is to trigger build on the operator project when the operand gets a new build. But I rather prefer the nightly build approach instead. To avoid too many operator builds in the same day when the operand changes many times in the same day.
There was a problem hiding this comment.
I would like to fix that in another PR
What
Temporary fix as docker images with git sha tags from branches other than main is causing issues on the nightly build of kuadrant. TL;RD: kuadrant nightly release pipeline is picking the latest (based on
last_modifiedattribute) image with git sha like tags. When limitador operator docker images with git sha tag are being created for branches, those were sometimes being picked for nightly tests instead of theHEADofmain.