Release button #151
Release button #151
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
==========================================
- Coverage 85.91% 85.41% -0.51%
==========================================
Files 19 19
Lines 994 994
==========================================
- Hits 854 849 -5
- Misses 92 95 +3
- Partials 48 50 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
didierofrivia
force-pushed
the
release-button
branch
from
46c6def to
fefa520
Compare
didierofrivia
requested review from
alexsnaps,
guicassolato and
adam-cattermole
didierofrivia
force-pushed
the
release-button
branch
from
fefa520 to
478279d
Compare
didierofrivia
force-pushed
the
release-button
branch
from
478279d to
0413891
Compare
|
I would have approved this but given I reviewed and also made changes perhaps another reviewer should take a look |
didierofrivia
force-pushed
the
release-button
branch
from
bcbb578 to
4c22569
Compare
.github/workflows/release.yaml
Outdated
| run: | | ||
| git config --global user.name "github-actions[bot]" | ||
| git config --global user.email "github-actions[bot]@users.noreply.github.com" | ||
| git add -A && git commit -m "Prepared release v${{ inputs.limitadorOperatorVersion }}" |
There was a problem hiding this comment.
| git add -A && git commit -m "Prepared release v${{ inputs.limitadorOperatorVersion }}" | |
| git add -A && git commit -s -m "Prepared release v${{ inputs.limitadorOperatorVersion }}" |
Should we also sign off the commits to meeet the DCO requirement for commits? 🤔
There was a problem hiding this comment.
I'm curious if that will work with the github-actions[bot] configuration we have here and whether it'll count as verified or not but worth a shot - can fix later if not, more info here https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#signature-verification-for-bots
Unsure if there's a signing key present in the actions and how to configure git to use it
There was a problem hiding this comment.
Will see soon enough if it's verified.. we might need to change it in authorino operator too in that case https://github.com/Kuadrant/authorino-operator/blob/main/.github/workflows/release.yaml#L58
There was a problem hiding this comment.
I think this should be fine since it's not signing commits (which uses the uppercase -S argument) using a signing key. It's adding a commit sign-off like Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> which I think meets the DCO requirement 🤔 Will see will this works though
didierofrivia
force-pushed
the
release-button
branch
from
4c22569 to
455c3aa
Compare
Signed-off-by: dd di cesare <[email protected]>
Signed-off-by: dd di cesare <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]> Signed-off-by: dd di cesare <[email protected]>
Signed-off-by: dd di cesare <[email protected]>
Signed-off-by: dd di cesare <[email protected]>
Signed-off-by: dd di cesare <[email protected]>
didierofrivia
force-pushed
the
release-button
branch
from
891af0e to
92d0d51
Compare
This PR introduces a new workflow for crafting a release, following the pattern used in Authorino Operator. It makes it convenient to trigger the workflow manually without the need to go through the process of creating a branch and manually triggering the make targets, committing and tagging.
It includes the building of both OLM manifests and Helm Charts.