Enhanced logging #14
Merged
Enhanced logging #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guicassolato
reviewed
Nov 2, 2021
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| "sigs.k8s.io/controller-runtime/pkg/client/fake" | ||
|
|
||
| "github.com/kuadrant/limitador-operator/pkg/helpers" | ||
| "github.com/kuadrant/limitador-operator/pkg/log" |
There was a problem hiding this comment.
What about importing the package from Kuadrant?
There was a problem hiding this comment.
that would be adding adding a dependency to kuadrant-controller, and the kuadrant-controller already has limitador operator as dependency https://github.com/Kuadrant/kuadrant-controller/blob/1d691f6a792cfc4bc0f39de7de3e6c2beba5488c/go.mod#L13
This circular dependency is what I wanted to avoid.
For me, this "shared" code should be part of some external module as suggested by @didierofrivia . When we have enough shared code to be in a external module, we could create it. Meanwhile, duplicating code is the least problematic issue, IMO.
guicassolato
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds better log levels and log configuration.
debug→info→error)production,development