Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: some constants for defined types #115

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Nov 15, 2023

No description provided.

Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
@eguzki eguzki requested a review from a team November 15, 2023 10:16
Copy link
Member

@alexsnaps alexsnaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I was thinking of adding these, now that I'm trying to use them in the kuadrant operator... that being said, I wondered if there was a way to expand them in the comments used by kubebuilder tho 🤔

@alexsnaps alexsnaps added this to the v0.7.0 milestone Nov 15, 2023
@eguzki
Copy link
Contributor Author

eguzki commented Nov 15, 2023

Thanks, I was thinking of adding these, now that I'm trying to use them in the kuadrant operator... that being said, I wondered if there was a way to expand them in the comments used by kubebuilder tho 🤔

Let me know if you find some way. controller-gen could generate code for that. It is actually honoring those kubebuilder comments when generating validations in the manifests. If it cannot be done, looks like a good feature request.

@eguzki eguzki merged commit c211b51 into main Nov 15, 2023
11 checks passed
@eguzki eguzki deleted the ratelimitheaderstypes branch November 15, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: To test
Development

Successfully merging this pull request may close these issues.

2 participants