Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed redundant default yaml output and adjusted docs to reflect new changes #80

Merged
merged 1 commit into from
May 21, 2024

Conversation

ehearneRedHat
Copy link
Contributor

In relation to #75 .

What:

  • removed redundant default yaml output and adjusted docs to reflect new changes

Verify:

To verify, compile binary from root directory on this branch using go build and run the following commands:

./kuadrantctl generate gatewayapi httproute --help
./kuadrantctl generate kuadrant authpolicy --help
./kuadrantctl generate kuadrant ratelimitpolicy --help

Verify that there is no longer any redundant yaml output as mentioned in #75 . Also verify that the docs changed don't mention the redundant default yaml ouput anymore.

@ehearneRedHat ehearneRedHat requested a review from eguzki May 20, 2024 09:08
@ehearneRedHat ehearneRedHat linked an issue May 20, 2024 that may be closed by this pull request
@ehearneRedHat
Copy link
Contributor Author

@eguzki feel free to review when you have the chance :)

Copy link
Collaborator

@eguzki eguzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehearneRedHat ehearneRedHat merged commit 9e23ead into main May 21, 2024
5 checks passed
@ehearneRedHat ehearneRedHat deleted the 75-redundant-default-yaml-in-help-command branch May 21, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant "default: yaml" in --help command
2 participants