Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several enhancements #77

Merged
merged 6 commits into from
Jun 4, 2024
Merged

Several enhancements #77

merged 6 commits into from
Jun 4, 2024

Conversation

eguzki
Copy link
Collaborator

@eguzki eguzki commented May 15, 2024

What

Giving some deserved love to the kuadrantctl

  • ginkgo v2
  • dev testing upgrade: k8s 1.29 and kind 0.22
  • remove unused leftovers (from install command)
  • gatewayapi v1.0.1 and kuadrant API v0.7.1

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 53 lines in your changes are missing coverage. Please review.

Project coverage is 0.48%. Comparing base (7296e1b) to head (b4397f5).
Report is 24 commits behind head on main.

Files Patch % Lines
pkg/utils/oas_utils.go 0.00% 14 Missing ⚠️
cmd/generate_kuadrant_authpolicy.go 0.00% 10 Missing ⚠️
cmd/generate_kuadrant_ratelimitpolicy.go 0.00% 8 Missing ⚠️
pkg/gatewayapi/http_route.go 0.00% 7 Missing ⚠️
cmd/generate_gatewayapi_httproute.go 0.00% 5 Missing ⚠️
pkg/kuadrantapi/authpolicy.go 0.00% 5 Missing ⚠️
pkg/kuadrantapi/rate_limit_policy.go 0.00% 2 Missing ⚠️
pkg/utils/kuadrant_oas_extension_types.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #77      +/-   ##
========================================
+ Coverage   0.38%   0.48%   +0.10%     
========================================
  Files         17      17              
  Lines        783     618     -165     
========================================
  Hits           3       3              
+ Misses       780     615     -165     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eguzki eguzki marked this pull request as ready for review May 15, 2024 16:27
@eguzki eguzki requested review from jasonmadigan and a team May 15, 2024 16:27
@jasonmadigan
Copy link
Member

gatewayapi v1.0.1 and kuadrant API v0.7.1

🥇 thanks @eguzki, was on my list and I appreciate smaller lists

Makefile Show resolved Hide resolved
Copy link
Member

@jasonmadigan jasonmadigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eguzki eguzki merged commit 3788cb7 into main Jun 4, 2024
5 checks passed
@eguzki eguzki deleted the general-enhancements branch June 4, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants