Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

several updates to bring the website main page more upto date #54

Merged
merged 14 commits into from
May 8, 2024

Conversation

maleck13
Copy link
Contributor

@maleck13 maleck13 commented May 8, 2024

@jasonmadigan Several updates here as a fair bit of the main page was out of date

@openshift-ci openshift-ci bot requested review from eguzki and Ygnas May 8, 2024 08:16
@openshift-ci openshift-ci bot added the approved label May 8, 2024
Copy link

netlify bot commented May 8, 2024

Deploy Preview for relaxed-faloodeh-7fa6f1 ready!

Name Link
🔨 Latest commit a45d9a8
🔍 Latest deploy log https://app.netlify.com/sites/relaxed-faloodeh-7fa6f1/deploys/663b80f8dbd5900009b3a039
😎 Deploy Preview https://deploy-preview-54--relaxed-faloodeh-7fa6f1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jasonmadigan jasonmadigan self-assigned this May 8, 2024
Copy link
Member

@jasonmadigan jasonmadigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small suggestions

src/index.njk Outdated Show resolved Hide resolved
src/index.njk Outdated Show resolved Hide resolved
src/index.njk Outdated Show resolved Hide resolved
src/index.njk Outdated Show resolved Hide resolved
src/index.njk Outdated Show resolved Hide resolved
src/index.njk Outdated Show resolved Hide resolved
maleck13 and others added 6 commits May 8, 2024 13:04
Co-authored-by: Jason Madigan <[email protected]>
Co-authored-by: Jason Madigan <[email protected]>
Co-authored-by: Jason Madigan <[email protected]>
Co-authored-by: Jason Madigan <[email protected]>
Co-authored-by: Guilherme Cassolato <[email protected]>
Co-authored-by: Guilherme Cassolato <[email protected]>
@maleck13
Copy link
Contributor Author

maleck13 commented May 8, 2024

@jasonmadigan @guicassolato accepted those changes

Copy link
Member

@jasonmadigan jasonmadigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few other edits to fix something I spotted earlier:

  • Old mkdocs builds had dumped docs into folders at the / of gh-pages. I need to remove these at some point, as they will go stale
  • For links to the latest stable docs for a topic, best to use /latest/ (/0.7.0/ works too, but then you'd have to amend frequently). /latest/ will always point at our most recent, stable tested docs.
  • The way mike works (still learning myself tbh) is that copies/versions of docs go into subfolders. Aliases get symlinked to these folders. No docs are pushed to the root of the file, other than index.html and the versions.json.

src/index.njk Outdated Show resolved Hide resolved
src/index.njk Outdated Show resolved Hide resolved
src/index.njk Outdated Show resolved Hide resolved
src/index.njk Outdated Show resolved Hide resolved
src/index.njk Outdated Show resolved Hide resolved
src/index.njk Outdated Show resolved Hide resolved
src/index.njk Outdated Show resolved Hide resolved
Copy link

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonmadigan, maleck13

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jasonmadigan,maleck13]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jasonmadigan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 8, 2024
@maleck13 maleck13 merged commit c7b9d97 into main May 8, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants