Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the integration tests is failing https://github.com/Kuadrant/kuadrant-operator/actions/runs/10625397804/job/29455286217#step:7:122
I think this is related to the changes to store as v1beta2. I can't quite pinpoint exactly why but before the
credentials
field had theauthorizationHeader
present (even though it'somitempty
), whereas now it does not - I'm guessing some logic in the webhook was incorrect and was creating an emptyPrefixed
so the pointer was not null - I've updated all 3 occurrences in the json string.Before:
After:
I believe the behaviour now looks correct but looking to @guicassolato or @alexsnaps to confirm.