Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release workflow #803

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Fix release workflow #803

merged 1 commit into from
Aug 14, 2024

Conversation

didierofrivia
Copy link
Member

Fixing the workflow adding the missing prerelease input and the correct version

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.84%. Comparing base (ece13e8) to head (a742430).
Report is 164 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
+ Coverage   80.20%   81.84%   +1.63%     
==========================================
  Files          64       76      +12     
  Lines        4492     6114    +1622     
==========================================
+ Hits         3603     5004    +1401     
- Misses        600      756     +156     
- Partials      289      354      +65     
Flag Coverage Δ
bare-k8s-integration 4.48% <ø> (?)
controllers-integration 71.82% <ø> (?)
gatewayapi-integration 10.97% <ø> (?)
integration ?
istio-integration 56.12% <ø> (?)
unit 31.45% <ø> (+1.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 71.42% <ø> (ø)
api/v1beta2 (u) 85.35% <80.00%> (-6.08%) ⬇️
pkg/common (u) 88.13% <ø> (-0.70%) ⬇️
pkg/istio (u) 72.50% <ø> (-1.41%) ⬇️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 83.64% <ø> (+4.19%) ⬆️
controllers (i) 82.07% <82.17%> (+5.26%) ⬆️

see 43 files with indirect coverage changes

@didierofrivia didierofrivia added the kind/bug Something isn't working label Aug 14, 2024
Copy link
Member

@adam-cattermole adam-cattermole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@didierofrivia didierofrivia merged commit ea9fb3e into main Aug 14, 2024
28 checks passed
@didierofrivia didierofrivia deleted the release-workflow-fix branch August 14, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants