Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default template with latest manifests #788

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

didierofrivia
Copy link
Member

No description provided.

@didierofrivia didierofrivia requested a review from a team as a code owner July 30, 2024 08:54
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.84%. Comparing base (ece13e8) to head (5a73152).
Report is 156 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #788      +/-   ##
==========================================
+ Coverage   80.20%   81.84%   +1.63%     
==========================================
  Files          64       77      +13     
  Lines        4492     6206    +1714     
==========================================
+ Hits         3603     5079    +1476     
- Misses        600      768     +168     
- Partials      289      359      +70     
Flag Coverage Δ
bare-k8s-integration 4.41% <ø> (?)
controllers-integration 71.60% <ø> (?)
gatewayapi-integration 10.97% <ø> (?)
integration ?
istio-integration 55.48% <ø> (?)
unit 31.69% <ø> (+1.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 71.42% <ø> (ø)
api/v1beta2 (u) 85.35% <80.00%> (-6.08%) ⬇️
pkg/common (u) 88.13% <ø> (-0.70%) ⬇️
pkg/istio (u) 72.50% <ø> (-1.41%) ⬇️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 83.64% <ø> (+4.19%) ⬆️
controllers (i) 82.33% <83.81%> (+5.53%) ⬆️

see 40 files with indirect coverage changes

Copy link
Member

@adam-cattermole adam-cattermole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm!

Maybe we can have the helm manifests auto-generated by the existing manifests make target (for simplicity), or/and have a check on PR to make sure we update these when we make a change to the manifests

@didierofrivia didierofrivia merged commit 3af0a49 into main Jul 30, 2024
28 checks passed
@didierofrivia didierofrivia deleted the update-helm-template branch July 30, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants