Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed app developer dashboard to new dashboard id #764

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

ehearneRedHat
Copy link
Contributor

@ehearneRedHat ehearneRedHat commented Jul 17, 2024

What:

Previous App Developer Dashboard Page on Grafana was faulty, not allowing users to use the Download JSON button due to a double upload of a revision.

New App Developer Dashboard Page has since been uploaded to Grafana, therefore the new ID has been amended in docs and workflow that deal with App Developer Dashboard Page on Grafana.

A follow up to this PR would be to update the docs 0.7.0, 0.8.0 and latest .

@ehearneRedHat ehearneRedHat requested a review from a team as a code owner July 17, 2024 14:42
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.03%. Comparing base (ece13e8) to head (9655a3f).
Report is 136 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #764      +/-   ##
==========================================
+ Coverage   80.20%   83.03%   +2.82%     
==========================================
  Files          64       77      +13     
  Lines        4492     5978    +1486     
==========================================
+ Hits         3603     4964    +1361     
- Misses        600      669      +69     
- Partials      289      345      +56     
Flag Coverage Δ
bare-k8s-integration 4.55% <ø> (?)
controllers-integration 72.85% <ø> (?)
gatewayapi-integration 11.12% <ø> (?)
integration ?
istio-integration 56.57% <ø> (?)
unit 33.23% <ø> (+3.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 71.42% <ø> (ø)
api/v1beta2 (u) 92.17% <94.11%> (+0.75%) ⬆️
pkg/common (u) 88.13% <ø> (-0.70%) ⬇️
pkg/istio (u) 73.88% <ø> (-0.03%) ⬇️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 83.33% <ø> (+3.87%) ⬆️
controllers (i) 82.25% <84.53%> (+5.45%) ⬆️

see 41 files with indirect coverage changes

@david-martin david-martin merged commit a4321ae into main Jul 18, 2024
27 checks passed
@ehearneRedHat
Copy link
Contributor Author

ehearneRedHat commented Jul 18, 2024 via email

ehearneRedHat added a commit that referenced this pull request Jul 18, 2024
* changed app developer dashboard to new dashboard id

* fix typo
ehearneRedHat added a commit that referenced this pull request Jul 22, 2024
* changed app developer dashboard to new dashboard id

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants