chore: Remove DNSRecord ownerID generation #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikenairn
force-pushed
the
remove_dnsrecord_owner_id_generation
branch
3 times, most recently
from
d9b9063 to
cb589a3
Compare
The `ownerID` field on DNSRecord is now optional, the dns operator will now ensure a valid unique ownerID for all DNSRecords if none is explicitly set.
mikenairn
force-pushed
the
remove_dnsrecord_owner_id_generation
branch
from
cb589a3 to
f846c99
Compare
mikenairn
commented
Jun 27, 2024
| })), | ||
| ) | ||
| }, tests.TimeoutMedium, time.Second).Should(Succeed()) | ||
| }, tests.TimeoutLong, time.Second).Should(Succeed()) |
There was a problem hiding this comment.
@makslion This test was sometimes failing. My guess is that previously one of the DNSRecords was never becoming ready due to Kuadrant/dns-operator#165 so it was consistently partially enforced. Now though they can both become ready so we should just wait for it to be fully enforced. Presumably that should happen relatively quickly in the test setup.
dlaw4608
pushed a commit
to dlaw4608/kuadrant-operator
that referenced
this pull request
Jul 3, 2024
Reconcile out of order gateway resource creation. (Kuadrant#638) * On gateway creation if no backrefs are found reconcile AuthPolices with a status of ACCEPTED: false and REASON: TargetNotFound. * using dag for reconcile trigger. * fix unit tests * Tidy up of some WIP code * Fix the out-of-order creation issue for authPolices. * Fix issues raised from the CI tests * Rebase updates * Fix integration test, sleep required for some reason. * Refactor to remove the need for switches. * Update unit tests to match refactor * Remove deprecated `FromInt` * Updates after rebase * small update to make lists. * rebase format fix * Revert time.sleep * Add logging for error message * Address comment request chore: Remove DNSRecord ownerID generation (Kuadrant#716) The `ownerID` field on DNSRecord is now optional, the dns operator will now ensure a valid unique ownerID for all DNSRecords if none is explicitly set. Add TargetRef to AuthPolicy and Fix Formatting and Integration Tests - Added TargetRef to AuthPolicy to specify the target reference. - Replaced the gateway object with the gateway wrapped inside the gatewayWrapper. - Fixed various errors and improved code formatting. - Resolved issues with Istio integration tests. This commit consolidates multiple changes made during the development process, improving the stability and functionality of the AuthPolicy controller and related tests. Add TargetRef to AuthPolicy and Fix Formatting and Integration Tests - Added TargetRef to AuthPolicy to specify the target reference. - Replaced the gateway object with the gateway wrapped inside the gatewayWrapper. - Fixed various errors and improved code formatting. - Resolved issues with Istio integration tests. This commit consolidates multiple changes made during the development process, improving the stability and functionality of the AuthPolicy controller and related tests. understanding worflow github actions example updated kind cluster version from v0.22.0 to v0.23.0, along with node image from v1.29.2 to v1.30.0 Removed unnecessary file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ownerIDfield on DNSRecord is now optional, the dns operator will ensure a valid unique ownerID for all DNSRecords if none is explicitly set.Requires: Kuadrant/dns-operator#170