add metrics for DNS events #707
Conversation
philbrookes
force-pushed
the
gh-453
branch
4 times, most recently
from
bc8cbfd to
4151f2e
Compare
|
ping @mikenairn @eguzki @maleck13 could I get a review here, when you have a chance? |
philbrookes
force-pushed
the
gh-453
branch
2 times, most recently
from
1c04299 to
f366404
Compare
| } | ||
|
|
||
| func (b *BaseReconciler) DeleteResource(ctx context.Context, obj client.Object, options ...client.DeleteOption) error { | ||
| logger, _ := logr.FromContext(ctx) | ||
| logger.Info("delete object", "kind", strings.Replace(fmt.Sprintf("%T", obj), "*", "", 1), "name", obj.GetName(), "namespace", obj.GetNamespace()) | ||
| return b.Client().Delete(ctx, obj, options...) | ||
| if obj.GetDeletionTimestamp() != nil { |
There was a problem hiding this comment.
Added a check here, to not reissue delete requests on items already deleting.
|
Since it was deemed that this was necessary for DNSPolicy, would the same not be true for all policies? Presumably this is intended to be used along some alert or dashboard that signals if CRUD operations are happening too frequently? |
I think this was deemed necessary for DNS Policy as it could result in excessive traffic to the DNS Provider API, which is not a problem with the other policies? |
Emit metrics for:
ping @mikenairn @eguzki
closes #453