Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] refactor: parrallel tests #657

Closed
wants to merge 5 commits into from
Closed

Conversation

KevFan
Copy link
Contributor

@KevFan KevFan commented May 22, 2024

No description provided.

@eguzki
Copy link
Contributor

eguzki commented May 22, 2024

What is the reasoning for this refactor? This PR conflicts with a WIP test refactor I am doing for making room to onboard EnvoyGateway. Basically I am creating "istio tests", so we can later add "envoy gateway tests".

@KevFan
Copy link
Contributor Author

KevFan commented May 22, 2024

What is the reasoning for this refactor? This PR conflicts with a WIP test refactor I am doing for making room to onboard EnvoyGateway. Basically I am creating "istio tests", so we can later add "envoy gateway tests".

@eguzki Just seeing how easy / difficult it is to do this / what issues are there and to see if it's worth it generally (can be seen as part of #564). Not particularly looking to merge this soon if it's a concern

@eguzki
Copy link
Contributor

eguzki commented May 23, 2024

I thought we had already did this parallel test thing, but it was on the limitador-operator Kuadrant/limitador-operator#134.

There is a big conflict with #645 but we will workout as needed. 👍

@KevFan KevFan force-pushed the parrallel-tests branch 2 times, most recently from 31d4ec8 to 2854f54 Compare May 29, 2024 15:59
@KevFan KevFan force-pushed the parrallel-tests branch from a00885d to 756f544 Compare May 30, 2024 12:16
@KevFan
Copy link
Contributor Author

KevFan commented Jun 5, 2024

Closing this and opening up another PR since it's a big rebase

@KevFan KevFan closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants