Update kube prometheus #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
==========================================
+ Coverage 80.20% 82.47% +2.26%
==========================================
Files 64 72 +8
Lines 4492 5414 +922
==========================================
+ Hits 3603 4465 +862
- Misses 600 637 +37
- Partials 289 312 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
david-martin
force-pushed
the
update-kube-prometheus
branch
from
78350af to
d8b012f
Compare
|
👀 |
ehearneRedHat
approved these changes
May 17, 2024
There was a problem hiding this comment.
@david-martin tested locally - all dashboards imported ok and looked reasonable. Also tested the new make target which works well. I made a suggestion to add where to save the files so that the make target can pick them up - feel free to commit suggestion if you like.
Either way, looks good to merge :)
Co-authored-by: Evan Hearne <[email protected]>
|
Thanks @ehearneRedHat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 3 related changes in this PR:
make dashboard-cleanupthat runs the already existinguniversal-dashboard.shscript on all dashboard json files. The readme has been udpated to reflect this change.1 other small change is a height increase to 1 to a table in the app developer dashboard as it is cropped after the upgrade to Grafana 9.
To verify, run the
quickstart-setup.shlocally, port forward to the grafana service and verify the dashboards all imported OK and look reasonable.