Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH action verify-generate #610

Merged
merged 1 commit into from
May 3, 2024
Merged

GH action verify-generate #610

merged 1 commit into from
May 3, 2024

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented May 3, 2024

What

Add GH action job to ensure make generate is run and prevent api/**/zz_generated.deepcopy.go from being outdated

@eguzki eguzki requested a review from a team as a code owner May 3, 2024 09:48
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.98%. Comparing base (ece13e8) to head (44d45a4).
Report is 68 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
+ Coverage   80.20%   81.98%   +1.77%     
==========================================
  Files          64       71       +7     
  Lines        4492     5261     +769     
==========================================
+ Hits         3603     4313     +710     
- Misses        600      639      +39     
- Partials      289      309      +20     
Flag Coverage Δ
integration 73.00% <ø> (+1.71%) ⬆️
unit 32.74% <ø> (+2.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 71.42% <ø> (ø)
api/v1beta2 (u) 93.58% <100.00%> (+2.16%) ⬆️
pkg/common (u) 83.78% <ø> (-5.05%) ⬇️
pkg/istio (u) 75.14% <ø> (+1.23%) ⬆️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 79.84% <ø> (+0.39%) ⬆️
controllers (i) 79.72% <83.73%> (+2.91%) ⬆️

see 27 files with indirect coverage changes

@eguzki eguzki merged commit 6c28e22 into main May 3, 2024
22 of 23 checks passed
@eguzki eguzki deleted the verify-generate branch May 3, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants