Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky invalid RLP/AP tests #558

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Conversation

guicassolato
Copy link
Contributor

@guicassolato guicassolato commented Apr 22, 2024

Avoid using shared Gateway object (istio-ingressgateway) in the tests.

@guicassolato guicassolato requested a review from a team as a code owner April 22, 2024 10:06
@guicassolato guicassolato self-assigned this Apr 22, 2024
@guicassolato guicassolato requested review from eguzki and KevFan April 22, 2024 10:06
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Merging #558 (52f7bad) into main (ece13e8) will increase coverage by 0.78%.
Report is 43 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
+ Coverage   80.20%   80.99%   +0.78%     
==========================================
  Files          64       72       +8     
  Lines        4492     5099     +607     
==========================================
+ Hits         3603     4130     +527     
- Misses        600      654      +54     
- Partials      289      315      +26     
Flag Coverage Δ
integration 72.25% <ø> (+0.96%) ⬆️
unit 32.74% <ø> (+2.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 71.42% <ø> (ø)
api/v1beta2 (u) 89.10% <100.00%> (-2.33%) ⬇️
pkg/common (u) 83.01% <ø> (-5.81%) ⬇️
pkg/istio (u) 75.14% <100.00%> (+1.23%) ⬆️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 79.84% <ø> (+0.39%) ⬆️
controllers (i) 77.75% <82.18%> (+0.95%) ⬆️

see 16 files with indirect coverage changes

Copy link
Collaborator

@maleck13 maleck13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@guicassolato guicassolato merged commit 478a880 into main Apr 22, 2024
21 checks passed
@guicassolato guicassolato deleted the fix-flaky-invalid-policy-tests branch April 22, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants