Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated HTTPRoute for ToysStore with new label. #524

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

david-martin
Copy link
Member

@david-martin david-martin commented Apr 9, 2024

  • Added a "deployment" label to the HTTPRoute resource so it can be tied to istio metrics

i.e. the destination_workload and destination_service_name labels on the istio_requests_total metric

@david-martin david-martin requested a review from a team as a code owner April 9, 2024 09:49
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Merging #524 (7c8e80c) into main (ece13e8) will increase coverage by 0.30%.
Report is 24 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
+ Coverage   80.20%   80.51%   +0.30%     
==========================================
  Files          64       70       +6     
  Lines        4492     4969     +477     
==========================================
+ Hits         3603     4001     +398     
- Misses        600      651      +51     
- Partials      289      317      +28     
Flag Coverage Δ
integration 71.38% <ø> (+0.10%) ⬆️
unit 33.43% <ø> (+3.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 71.42% <ø> (ø)
api/v1beta2 (u) 88.51% <100.00%> (-2.92%) ⬇️
pkg/common (u) 83.01% <ø> (-5.81%) ⬇️
pkg/istio (u) 75.14% <100.00%> (+1.23%) ⬆️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 79.77% <100.00%> (+0.31%) ⬆️
controllers (i) 76.31% <82.44%> (-0.49%) ⬇️

see 10 files with indirect coverage changes

Copy link
Member

@jasonmadigan jasonmadigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Added a "deployment" label to the HTTPRoute resource so it can be tied to istio metrics
@david-martin
Copy link
Member Author

@jasonmadigan added a service label as well for matching with destination_service_name so aggregating can be done per httproute (which isn't possible with destination_workload in cases of 429s where it's set to unknown)

@david-martin david-martin merged commit 7d84371 into main Apr 11, 2024
21 checks passed
@david-martin david-martin deleted the httproute-labels branch April 11, 2024 09:55
philbrookes pushed a commit that referenced this pull request Apr 16, 2024
- Added a "deployment" & "service" label to the HTTPRoute resource so it can be tied to istio metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants