Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend the message for no records present whil updating enforced condition #510

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

maksymvavilov
Copy link
Contributor

providing more detailed message for one of the cases when enforced = false

@maksymvavilov maksymvavilov requested a review from a team as a code owner March 26, 2024 11:33
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Merging #510 (a32158c) into main (ece13e8) will decrease coverage by 0.03%.
Report is 11 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
- Coverage   80.20%   80.18%   -0.03%     
==========================================
  Files          64       64              
  Lines        4492     4516      +24     
==========================================
+ Hits         3603     3621      +18     
- Misses        600      601       +1     
- Partials      289      294       +5     
Flag Coverage Δ
integration 71.27% <100.00%> (-0.01%) ⬇️
unit 29.88% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 71.42% <ø> (ø)
api/v1beta2 (u) 91.42% <ø> (ø)
pkg/common (u) 88.82% <ø> (ø)
pkg/istio (u) 73.91% <ø> (ø)
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) 64.04% <ø> (ø)
pkg/rlptools (u) 79.45% <ø> (ø)
controllers (i) 76.83% <75.00%> (+0.03%) ⬆️
Files Coverage Δ
controllers/dnspolicy_status.go 81.39% <100.00%> (-4.97%) ⬇️

... and 8 files with indirect coverage changes

@maksymvavilov maksymvavilov force-pushed the policy-enforced-message branch from f52dc00 to a32158c Compare March 27, 2024 10:06
@maleck13 maleck13 merged commit 4f6a138 into main Mar 27, 2024
21 checks passed
@eguzki eguzki deleted the policy-enforced-message branch March 27, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants