Fixes of Secure, connect and protect guide #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eguzki
requested changes
Mar 20, 2024
trepel
force-pushed
the
secure-connect-fix
branch
from
27fda2c to
ede4a47
Compare
eguzki
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Small fixes of "Secure, connect and protect" guide. What was done:
dnsrecord.kuadrant.ioneeds to be used since it conflicts withdnsrecord.ingres.operator.openshift.io--context kind-kuadrant-localjust for the sake of consistencyresponseconfig to AuthPolicy, same is used in https://docs.kuadrant.io/kuadrant-operator/doc/user-guides/authenticated-rl-for-app-developers/whenselector. If not present Bob won't get the extra request compared to Alice since both limits will be applied and the most restrictive wins--resolveflag might not be used if DNS was properly configuredVerification Steps
Eye review might suffice since the changes are relatively simple. Optionally you can just follow the guide.