Adding packages other than controllers to the code coverage report from the integration tests
#425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
===========================================
+ Coverage 66.49% 80.38% +13.88%
===========================================
Files 38 40 +2
Lines 3901 3140 -761
===========================================
- Hits 2594 2524 -70
+ Misses 1123 414 -709
- Partials 184 202 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Cleanup controller-runtime’s envtest environment to run e2e tests as it is not being used
eguzki
changed the title
eguzki
changed the title
controllers to the code coverage report from the integration tests
KevFan
approved these changes
Feb 16, 2024
mikenairn
reviewed
Feb 16, 2024
| -tags integration \ | ||
| --fail-fast \ | ||
| -v \ | ||
| $(INTEGRATION_TEST_SUITE_PATHS) |
adam-cattermole
added a commit
that referenced
this pull request
Jun 11, 2024
Add back fail-fast removed in #425
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adding packages other than
controllersto the code coverage report from the integration tests has increased ~14% the full code coverage 🎉Makes sense. Integration tests also run code other than in the
controllerspackage that was not covered with the unit testsAdditionally:
./controllers/...)codecov/codecov-action@v4