Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walkthrough text updates and quickstart.sh missing space fix #413

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

trepel
Copy link
Contributor

@trepel trepel commented Feb 1, 2024

Small walkthrough text upades
Added missing space - the if does not work as expected without it

@trepel trepel requested a review from a team as a code owner February 1, 2024 16:34
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Merging #413 (387eb50) into main (45b81bb) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #413   +/-   ##
=======================================
  Coverage   66.26%   66.26%           
=======================================
  Files          38       38           
  Lines        3901     3901           
=======================================
  Hits         2585     2585           
  Misses       1129     1129           
  Partials      187      187           
Flag Coverage Δ
unit 60.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 78.59% <ø> (ø)
pkg/istio (u) 37.11% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.44% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 71.39% <ø> (ø)

@trepel trepel force-pushed the small-walkthrough-fixes branch from fdd5a16 to 387eb50 Compare February 2, 2024 10:53
Copy link
Member

@adam-cattermole adam-cattermole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, thanks!

@adam-cattermole adam-cattermole merged commit 133645e into Kuadrant:main Feb 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants