Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small enhancements to building actions #360

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Dec 6, 2023

  • Do daily scheduled builds instead of weekly
    • Scheduled it at 1am so the gather job can finish in time
  • Use SHAs only for scheduled build
    • It does not make sense as the rest of the components is only fixed in scheduled builds.
    • Should help with "mess" in Quay

@pehala pehala requested a review from didierofrivia December 6, 2023 08:29
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #360 (ed539e7) into main (62ff20d) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
+ Coverage   65.32%   65.35%   +0.02%     
==========================================
  Files          35       35              
  Lines        3804     3804              
==========================================
+ Hits         2485     2486       +1     
  Misses       1126     1126              
+ Partials      193      192       -1     
Flag Coverage Δ
integration 70.67% <ø> (+0.04%) ⬆️
unit 59.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 76.92% <ø> (ø)
pkg/istio (u) 30.24% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.21% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 70.67% <ø> (+0.04%) ⬆️

see 4 files with indirect coverage changes

@@ -63,7 +67,7 @@ on:
type: string

env:
IMG_TAGS: ${{ github.sha }} ${{ inputs.kuadrantOperatorTag }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so no more sha tags in our images by default... I reckon we are not using them for anything else than the QE builds, no?

@pehala pehala marked this pull request as ready for review December 6, 2023 11:33
@pehala pehala requested a review from a team as a code owner December 6, 2023 11:33
Copy link
Member

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍺

@pehala pehala merged commit d1b8ddd into Kuadrant:main Dec 7, 2023
15 checks passed
maleck13 pushed a commit to maleck13/kuadrant-operator that referenced this pull request Dec 12, 2023
* Use SHA only for scheduled builds

* Run scheduled build daily
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants