-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small enhancements to building actions #360
Conversation
pehala
commented
Dec 6, 2023
- Do daily scheduled builds instead of weekly
- Scheduled it at 1am so the gather job can finish in time
- Use SHAs only for scheduled build
- It does not make sense as the rest of the components is only fixed in scheduled builds.
- Should help with "mess" in Quay
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
==========================================
+ Coverage 65.32% 65.35% +0.02%
==========================================
Files 35 35
Lines 3804 3804
==========================================
+ Hits 2485 2486 +1
Misses 1126 1126
+ Partials 193 192 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -63,7 +67,7 @@ on: | |||
type: string | |||
|
|||
env: | |||
IMG_TAGS: ${{ github.sha }} ${{ inputs.kuadrantOperatorTag }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so no more sha tags in our images by default... I reckon we are not using them for anything else than the QE builds, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍺
* Use SHA only for scheduled builds * Run scheduled build daily