Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop watching authconfig #355

Closed
wants to merge 1 commit into from
Closed

stop watching authconfig #355

wants to merge 1 commit into from

Conversation

guicassolato
Copy link
Contributor

@guicassolato guicassolato commented Dec 4, 2023 •
edited
Loading

Continuing on #352

@guicassolato guicassolato requested a review from a team as a code owner December 4, 2023 13:52
@guicassolato guicassolato self-assigned this Dec 4, 2023
@guicassolato guicassolato added the kind/bug Something isn't working label Dec 4, 2023
@guicassolato guicassolato added this to the v0.5.0 milestone Dec 4, 2023
@guicassolato guicassolato force-pushed the revert-authconfig-owner-ref branch 2 times, most recently from 13d94da to f88bd64 Compare December 4, 2023 13:56
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

Merging #355 (f88bd64) into main (2acf31b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
- Coverage   65.31%   65.30%   -0.01%     
==========================================
  Files          35       35              
  Lines        3800     3799       -1     
==========================================
- Hits         2482     2481       -1     
  Misses       1125     1125              
  Partials      193      193
Flag Coverage Δ
unit 59.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 76.92% <ø> (ø)
pkg/istio (u) 30.24% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.33% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 70.51% <ø> (-0.02%) ⬇️
Files Coverage Δ
controllers/authpolicy_controller.go 75.86% <ø> (-0.17%) ⬇️

@guicassolato guicassolato marked this pull request as draft December 4, 2023 15:17
@guicassolato
Copy link
Contributor Author

Superseded by #356

@guicassolato guicassolato deleted the revert-authconfig-owner-ref branch December 4, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@guicassolato guicassolato

Labels
kind/bug Something isn't working
Projects
Kuadrant
Archived in project
Kuadrant Service Protection
Status: To test
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@guicassolato