Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Istio AuthorizationPolicy mutate check #351

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

guicassolato
Copy link
Contributor

No description provided.

@guicassolato guicassolato requested a review from a team as a code owner December 1, 2023 15:39
Copy link
Member

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛 🔫

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #351 (c8fb703) into main (b736a7b) will decrease coverage by 0.74%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   65.42%   64.68%   -0.74%     
==========================================
  Files          35       35              
  Lines        3800     3800              
==========================================
- Hits         2486     2458      -28     
- Misses       1122     1142      +20     
- Partials      192      200       +8     
Flag Coverage Δ
integration 69.34% <0.00%> (-1.39%) ⬇️
unit 59.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 76.92% <ø> (ø)
pkg/istio (u) 30.24% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.33% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 69.34% <0.00%> (-1.39%) ⬇️
Files Coverage Δ
...ontrollers/authpolicy_istio_authorizationpolicy.go 68.32% <0.00%> (-4.59%) ⬇️

... and 2 files with indirect coverage changes

@guicassolato guicassolato merged commit f97417a into main Dec 1, 2023
17 of 18 checks passed
@guicassolato guicassolato deleted the fix/istio-ap-mutate-fn branch December 1, 2023 16:12
maleck13 pushed a commit to maleck13/kuadrant-operator that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants