remove deployment of policy-controller for now

[maleck13]

When we deploy a hub and spoke in the same cluster, we end up with two policy controllers running. So rather than rush into this deployment model, going to remove the policy controller from the kuadrant-operator CSV for now. We will update a the docs and explain that in a single cluster you can use the policy-controller in a single cluster and provide a command to install via kustomize

Kuadrant/multicluster-gateway-controller#693

[codecov]

Codecov Report

Merging #338 (a81859e) into main (cb9d3d5) will increase coverage by 0.31%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   64.44%   64.76%   +0.31%     
==========================================
  Files          35       35              
  Lines        3794     3794              
==========================================
+ Hits         2445     2457      +12     
+ Misses       1156     1146      -10     
+ Partials      193      191       -2     

Flag	Coverage Δ
integration	70.53% <ø> (+0.59%)	⬆️
unit	58.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
api/v1beta1 (u)	∅ <ø> (∅)
pkg/common (u)	73.92% <ø> (ø)
pkg/istio (u)	30.24% <ø> (ø)
pkg/log (u)	31.81% <ø> (ø)
pkg/reconcilers (u)	33.68% <ø> (ø)
pkg/rlptools (u)	56.46% <ø> (ø)
controllers (i)	70.53% <ø> (+0.59%)	⬆️

see 4 files with indirect coverage changes

[mikenairn]

You'll need to manually remove the CRDs and Roles added by the policy-controller from here https://github.com/Kuadrant/kuadrant-operator/tree/main/bundle/manifests. The bundle command doesn't remove these unfortunately.

[didierofrivia]

I reckon we can leave the targets for metallb even if atm there's no practical use for those.

[mikenairn]

I reckon we can leave the targets for metallb even if atm there's no practical use for those.

fyi, we plan to still add these docs but with an extra step to install the policy-controller #322, this will still require metallb.

[maleck13]

@didierofrivia I see the integration tests failed. I don't think they are to do with this change. Still ok to merge?

[mikenairn]

I reckon we can leave the targets for metallb even if atm there's no practical use for those.

fyi, we plan to still add these docs but with an extra step to install the policy-controller #322, this will still require metallb.

Docs PR is updated now #322 @maleck13 @didierofrivia fyi

[didierofrivia]

@maleck13 rebasing with main should fix the test failing

[maleck13]

@didierofrivia still looks to be failing any help would be appreciated . Seems to also be failing on just a docs update #322