Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Limitador CR condition ready #324

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Using Limitador CR condition ready #324

merged 1 commit into from
Nov 21, 2023

Conversation

didierofrivia
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #324 (2599738) into main (0c9289d) will increase coverage by 0.73%.
The diff coverage is 80.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
+ Coverage   64.08%   64.81%   +0.73%     
==========================================
  Files          35       35              
  Lines        3787     3786       -1     
==========================================
+ Hits         2427     2454      +27     
+ Misses       1162     1142      -20     
+ Partials      198      190       -8     
Flag Coverage Δ
integration 70.64% <80.00%> (+1.37%) ⬆️
unit 58.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 73.92% <ø> (ø)
pkg/istio (u) 30.24% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.68% <ø> (ø)
pkg/rlptools (u) 56.41% <ø> (ø)
controllers (i) 70.64% <80.00%> (+1.37%) ⬆️
Files Coverage Δ
controllers/kuadrant_status.go 73.72% <80.00%> (+3.98%) ⬆️

... and 3 files with indirect coverage changes

@didierofrivia didierofrivia force-pushed the check-limitador-ready branch 3 times, most recently from 8a5805f to f5dbf56 Compare November 21, 2023 17:35
@didierofrivia didierofrivia marked this pull request as ready for review November 21, 2023 17:36
@didierofrivia didierofrivia requested a review from a team as a code owner November 21, 2023 17:36
@didierofrivia didierofrivia requested a review from eguzki November 21, 2023 17:36
@alexsnaps alexsnaps added this to the v0.5.0 milestone Nov 21, 2023
@alexsnaps alexsnaps merged commit 5a3be48 into main Nov 21, 2023
21 checks passed
@alexsnaps alexsnaps deleted the check-limitador-ready branch November 21, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Status: To test
Development

Successfully merging this pull request may close these issues.

3 participants