-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a ServiceMeshMember, rather than mutating the ServiceMeshMembe… #198
Conversation
will see if I can use the old OpenShift instance (if I remember my credentials) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires new permissions to the Kuadrant controller. Please see
//+kubebuilder:rbac:groups=maistra.io,resources=servicemeshmemberrolls,verbs=get;list;watch;create;update;delete;patch |
and the details of how this change affects the flow described at https://access.redhat.com/documentation/en-us/openshift_container_platform/4.2/html-single/service_mesh/index#ossm-member-roll-create-member_installing-ossm – specifically:
While project administrators are automatically given permission to create the
ServiceMeshMember
resource in their project, they cannot point it to anyServiceMeshControlPlane
until the service mesh administrator explicitly grants access to the service mesh.
} | ||
func (r *KuadrantReconciler) registerServiceMeshMember(ctx context.Context, kObj *kuadrantv1beta1.Kuadrant) error { | ||
member := buildServiceMeshMember(kObj) | ||
err := r.SetOwnerReference(kObj, member) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
398748a
to
d65c23f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!
…rRoll