Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a ServiceMeshMember, rather than mutating the ServiceMeshMembe… #198

Merged
merged 2 commits into from
May 31, 2023

Conversation

alexsnaps
Copy link
Member

…rRoll

@alexsnaps alexsnaps requested a review from a team as a code owner May 30, 2023 20:03
@alexsnaps alexsnaps requested a review from didierofrivia May 30, 2023 20:03
@didierofrivia
Copy link
Member

will see if I can use the old OpenShift instance (if I remember my credentials)

Copy link
Contributor

@guicassolato guicassolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires new permissions to the Kuadrant controller. Please see

//+kubebuilder:rbac:groups=maistra.io,resources=servicemeshmemberrolls,verbs=get;list;watch;create;update;delete;patch

and the details of how this change affects the flow described at https://access.redhat.com/documentation/en-us/openshift_container_platform/4.2/html-single/service_mesh/index#ossm-member-roll-create-member_installing-ossm – specifically:

While project administrators are automatically given permission to create the ServiceMeshMember resource in their project, they cannot point it to any ServiceMeshControlPlane until the service mesh administrator explicitly grants access to the service mesh.

}
func (r *KuadrantReconciler) registerServiceMeshMember(ctx context.Context, kObj *kuadrantv1beta1.Kuadrant) error {
member := buildServiceMeshMember(kObj)
err := r.SetOwnerReference(kObj, member)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@alexsnaps alexsnaps force-pushed the issue-197 branch 2 times, most recently from 398748a to d65c23f Compare May 31, 2023 13:09
Copy link
Contributor

@guicassolato guicassolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@alexsnaps alexsnaps merged commit 6e7e239 into main May 31, 2023
@alexsnaps alexsnaps deleted the issue-197 branch May 31, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants