Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bundle generation #158

Merged
merged 4 commits into from
Apr 5, 2023
Merged

Fix bundle generation #158

merged 4 commits into from
Apr 5, 2023

Conversation

didierofrivia
Copy link
Member

This PR aims to fix the bundle image generation, which currently is listing wrong versions, then makes it fail the catalog generation:

https://github.com/Kuadrant/kuadrant-operator/actions/runs/4598777582/jobs/8123707273

[ERROR] Referenced Limitador version is , but found 0.0.0 in the bundle 
make[1]: *** [make/catalog.mk:26: /home/runner/work/kuadrant-operator/kuadrant-operator/catalog/kuadrant-operator-catalog/operator.yaml] Error 1
make[1]: Leaving directory '/home/runner/work/kuadrant-operator/kuadrant-operator'
make: *** [make/catalog.mk:35: catalog] Error 2

The following will be applied:

  • Version will be either semantic or github.sha
  • Tag will be latest when main branch, semantic when release and github.sha as default
  • The final images will be tagged with a combo of sha, latest, branch and semantic as applicable

@didierofrivia didierofrivia requested review from eguzki and pehala April 4, 2023 09:58
@didierofrivia didierofrivia self-assigned this Apr 4, 2023
@didierofrivia didierofrivia requested a review from a team as a code owner April 4, 2023 09:58
@didierofrivia didierofrivia requested a review from alexsnaps April 4, 2023 10:01
eguzki
eguzki requested changes Apr 4, 2023
View reviewed changes
.github/workflows/build-images.yaml Show resolved Hide resolved
Makefile Show resolved Hide resolved
@didierofrivia
[gh workflow] Fix tag and version sent to bundle target
5e6d319 
* Version will be either semantic or sha
* Tag will be `latest` when main branch, `semantic` when release and
  `sha` as default
* The images will be tagged with a combo of sha, latest, branch and
  semantic as applicable
@didierofrivia
[makefile] Removing duplicated tag assignment
86069f8
@didierofrivia didierofrivia force-pushed the fix-bundle-generation branch from 17c60e1 to 86069f8 Compare April 4, 2023 13:30
@didierofrivia
Copy link
Member Author

Still not fixing the main issue, will do more debugging

@didierofrivia didierofrivia marked this pull request as draft April 4, 2023 13:52
@didierofrivia didierofrivia marked this pull request as ready for review April 4, 2023 14:34
@didierofrivia
Copy link
Member Author

Fixed for regular bundle builds, once merged, will do a test for workflow_dispatch

@didierofrivia didierofrivia requested a review from eguzki April 4, 2023 14:35
eguzki
eguzki requested changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@eguzki eguzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to move the SHELL makefile var to the top

make bundle
/bin/sh: 1: Syntax error: "(" unexpected

@didierofrivia didierofrivia requested a review from eguzki April 5, 2023 14:34
@didierofrivia didierofrivia merged commit 1b60f5f into main Apr 5, 2023
@didierofrivia didierofrivia deleted the fix-bundle-generation branch April 5, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pehala pehala pehala approved these changes

@eguzki eguzki eguzki approved these changes

@alexsnaps alexsnaps alexsnaps approved these changes

Assignees

@didierofrivia didierofrivia

Labels
None yet
Projects
No open projects
Kuadrant Service Protection
Status: To test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@didierofrivia @alexsnaps @eguzki @pehala