fix: ComputeGatewayDiffs when missing target HTTPRoute
#139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eguzki
reviewed
Jan 13, 2023
guicassolato
force-pushed
the
fix/net-resource-not-found
branch
2 times, most recently
from
1ec9115 to
ba5477e
Compare
|
Flagging this as WIP so we can fix as well other points where reconciliation fails due to missing the targeted HTTPRoute. |
guicassolato
changed the title
ComputeGatewayDiffs when missing target HTTPRoute
guicassolato
force-pushed
the
fix/net-resource-not-found
branch
from
ba5477e to
4dcd7de
Compare
…t is missing (#142) * fix: reconciliation of implementation resources when the network object is missing * RateLimitPolicy - EnvoyFilter - WasmPlugin * AuthPolicy - IstioAuthorizationPolicy * fix: envoyfilter and wasmplugin cleanup * fix: race condition between resource cleanup and back ref annotation removal * refactor: gateway and httproute to policy event mappers + set gateway event mapper to the authpolicyreconciler * refactor: dry: read k8s object annotations * debug log added to the authpolicy reconciler: print the policy as json * fix: race condition between handling network object not found and policy marked for deletion + partial rollback of the previous race condition fix: cleanup and back ref annotation * fix: gateways should refer no deleted policies * gitignore tmp * reconcile istio authorizationpolicies and authorino authconfigs only when specs or annotations differ between existing and desired * refactor: rename target network object variables and refs for clarity
- `ctx` unused in `istioAuthorizationPolicyRules` function - eliminating type assertions in switch case by assigning the result of the assertion to a variable - using copy() instead of a loop to copy slice - avoid copying a sync.Mutex when using reflect.DeepEqual on istio.io/api/security/v1beta1.AuthorizationPolicy.Spec
… AuthPolicy controller
guicassolato
requested review from
didierofrivia and
eguzki
and removed request for
eguzki
didierofrivia
approved these changes
Jan 26, 2023
mikenairn
pushed a commit
to mikenairn/kuadrant-operator
that referenced
this pull request
Mar 23, 2023
* fix examples/toystore/ratelimitpolicy.yaml * run lint check from makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #138