Improved Kuadrant installation via Olm and kustomize #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleck13
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1075 +/- ##
==========================================
+ Coverage 76.15% 83.73% +7.57%
==========================================
Files 111 81 -30
Lines 8986 6712 -2274
==========================================
- Hits 6843 5620 -1223
+ Misses 1852 872 -980
+ Partials 291 220 -71
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: craig <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED more detailed installation guide and examples rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
maleck13
force-pushed
the
olm-installation
branch
from
77c9151 to
93292e8
Compare
R-Lawton
reviewed
Dec 12, 2024
Signed-off-by: craig <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: craig <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: craig <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: craig <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
| Re-Apply the configuration to setup the new secret and configuration: | ||
|
|
||
| ```bash | ||
| kubectl apply -k $KUADRANT_DIR/configure/ |
There was a problem hiding this comment.
This fails with an error
kubectl apply -k $KUADRANT_DIR/configure/
error: no resource matches strategic merge patch "Limitador.v1alpha1.limitador.kuadrant.io/limitador.kuadrant-system": no matches for Id Limitador.v1alpha1.limitador.kuadrant.io/limitador.kuadrant-system; failed to find unique target for patch Limitador.v1alpha1.limitador.kuadrant.io/limitador.kuadrant-systemPresumably becuase the Limitador CR is not part of the resources included in the kustomization, but you want to patch it.
There was a problem hiding this comment.
Probably related to changes below https://github.com/Kuadrant/kuadrant-operator/pull/1075/files#diff-36411ee7f394bd28aaa769d3b33d193cde1e03f8f7bb3fd569b2efb1b4a509f0R4
would need to land that on the v1.0.1 branch
There was a problem hiding this comment.
Yes I want to cherry pick these changes to the v1.0.1 branch. In the validation steps I mentioned you would have to use the ref=olm-installation for the resources .
david-martin
requested changes
Dec 19, 2024
Co-authored-by: David Martin <[email protected]>
Co-authored-by: David Martin <[email protected]>
Co-authored-by: David Martin <[email protected]>
Co-authored-by: David Martin <[email protected]>
Signed-off-by: craig <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
david-martin
approved these changes
Dec 20, 2024
|
/cherry-pick release-v1.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This updates the install with more details and hopefully clearer instructions.
The guide is focused around OLM and kustomize. Having this doesn't mean we can't also have a helm or kustomize without an OLM requirement
Verfication
Follow the guide without needing to clone the repo, You should be able to use a basic kind cluster.
Note
You will have to set the version in the configure/kustomization.yaml resource paths from
v1.0.1toolm-installationas some of the changes on this branch are not yet on the v1.0.1 branchStill to do